feat: add Windows and Linux support - #43
Open
amurph491 wants to merge 3 commits into
Open
Conversation
Replace macOS Keychain (`security` command) dependency with a Python credential helper that abstracts credential storage across macOS (Keychain), Windows (Credential Manager via ctypes), and Linux (secret-tool/libsecret). Update the token refresh hook to detect python3/python/py and use the credential helper. Fix non-portable stat/tmp paths in the assets skill. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Fix python3 Microsoft Store stub detection by trying py/python before python3 on Windows and validating each candidate with `import sys`. Add jq-free fallback so the hook works without jq installed. Replace `echo | base64` with `curl -u` in the manual configure flow to avoid Git Bash encoding issues. Document Windows prerequisites (Git for Windows, jq) and add troubleshooting entries. Tested e2e on Windows 11 ARM in Parallels: credential helper round-trip, hook with and without jq, and a live Spotify Ads API call via Claude Code. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
fix: Windows compatibility for hook and configure flow
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
scripts/credential-helper.py— a cross-platform credential storage script (stdlib only) that replaces the macOS-onlysecuritycommand. Uses macOS Keychain, Windows Credential Manager (via ctypes), or Linux secret-tool depending on platform.hooks/check-token.shto use the credential helper and detectpython3/python/pyinstead of hardcodingpython3.skills/configure/SKILL.mdto replace allsecuritycommands with credential helper calls.stat//tmp/paths inskills/assets/SKILL.md(cross-platformstatfallback,mktemp -dfor temp directory).Test plan